landing_worker: various changes to configuration (bug 1940565) #201
+251
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeid
changed the title
zzzeid
changed the title
zzzeid
force-pushed
the
zeid/bug-1940565-allow-worker-model-overrides
branch
4 times, most recently
from
fc9e54a to
a988d24
Compare
zzzeid
force-pushed
the
zeid/bug-1940565-allow-worker-model-overrides
branch
4 times, most recently
from
d80f672 to
adadfdf
Compare
- remove configuration variables that relate to workers - pass worker instance to base worker - implement functionality in worker to fetch up to date config - rename fields for consistency - update tests and fixtures - update maintenance
zzzeid
force-pushed
the
zeid/bug-1940565-allow-worker-model-overrides
branch
from
adadfdf to
ee9eff2
Compare
zzzeid
commented
Jan 31, 2025
shtrom
approved these changes
Feb 3, 2025
…w-worker-model-overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly adds the ability to configure landing workers on-the-fly without
the need to restart them after changes.