create_environment_repos: allow running command on prod (bug 1944072) #204
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zzzeid
commented
Jan 27, 2025
zzzeid
commented
- also add newest ESR repo
- improve logging
- also add newest ESR repo - improve logging
zzzeid
force-pushed
the
zeid/bug-1944072-add-prod-repos
branch
from
2dd1485 to
57ba098
Compare
cgsheeh
approved these changes
Jan 28, 2025
| @@ -252,6 +252,15 @@ | |||
| "milestone_tracking_flag_template": "cf_status_firefox_esr{milestone}", | |||
| "commit_flags": [DONTBUILD], | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
We define these repos as dicts, then when using them we do Repo.objects.create(**definition). Perhaps it would make more sense to define these as Repo and then create them with repo.save() instead.
There was a problem hiding this comment.
On production this is basically a single use script. On other environments, it will be reused so it is worth improving it some more if we feel the need. I think this is pretty good as is for the time being, but we can consider these improvements for the future.
cgsheeh
added a commit
that referenced
this pull request
Feb 24, 2025
…(Bug 1897044) (#204) The `error` and `exception` level logging calls cause Sentry to treat expected states as new issues. Lower the level to `info` to quiet down Sentry. Issues experienced by the Treestatus API will still show up in the LandoAPI logs, and at the `info` level we can still debug which code paths are taken by various requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.