Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: add legacy_source field and functionality (bug 1944341) #210

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Jan 29, 2025

  • add Repo.legacy_source
  • when requesting a landing, detect legacy source repo
  • redirect landing requests to new target repo
  • add models
  • update landing preview modal to show legacy source
  • move some test fixtures to conftest
  • add tests
  • update .gitignore to pick up more files

@zzzeid zzzeid force-pushed the zeid/bug-1944341-legacy-repo-linking branch 4 times, most recently from 758a272 to 0052596 Compare January 30, 2025 14:57
@zzzeid zzzeid changed the base branch from main to zeid/bug-1944851-cleanup-tests January 30, 2025 14:58
@zzzeid zzzeid force-pushed the zeid/bug-1944341-legacy-repo-linking branch from 0052596 to c8556f9 Compare January 30, 2025 14:59
Base automatically changed from zeid/bug-1944851-cleanup-tests to main January 30, 2025 15:00
@zzzeid zzzeid force-pushed the zeid/bug-1944341-legacy-repo-linking branch from c8556f9 to 2bcd3f0 Compare January 30, 2025 15:00
@zzzeid zzzeid requested review from shtrom and cgsheeh January 30, 2025 15:27
Copy link
Member

@shtrom shtrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zzzeid zzzeid force-pushed the zeid/bug-1944341-legacy-repo-linking branch 2 times, most recently from 64ba9d8 to 1bbe90e Compare January 31, 2025 14:27
@zzzeid zzzeid marked this pull request as ready for review January 31, 2025 14:31
- add Repo.legacy_source
- when requesting a landing, detect legacy source repo
- redirect landing requests to new target repo
- add models
- update landing preview modal to show legacy source
- move some test fixtures to conftest
- add tests
- update .gitignore to pick up more files
@zzzeid zzzeid force-pushed the zeid/bug-1944341-legacy-repo-linking branch from 1bbe90e to b74f143 Compare January 31, 2025 14:34
@zzzeid zzzeid requested a review from shtrom January 31, 2025 20:47
Copy link
Member

@shtrom shtrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions inline.

src/lando/main/models/repo.py Show resolved Hide resolved
src/lando/main/models/repo.py Outdated Show resolved Hide resolved
src/lando/ui/legacy/revisions.py Show resolved Hide resolved
@zzzeid zzzeid requested a review from shtrom February 4, 2025 19:49
@zzzeid zzzeid merged commit cd1aa07 into main Feb 5, 2025
1 check passed
@zzzeid zzzeid deleted the zeid/bug-1944341-legacy-repo-linking branch February 5, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants