-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo: add legacy_source field and functionality (bug 1944341) #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zzzeid
commented
Jan 29, 2025
•
edited
Loading
edited
- add Repo.legacy_source
- when requesting a landing, detect legacy source repo
- redirect landing requests to new target repo
- add models
- update landing preview modal to show legacy source
- move some test fixtures to conftest
- add tests
- update .gitignore to pick up more files
zzzeid
force-pushed
the
zeid/bug-1944341-legacy-repo-linking
branch
4 times, most recently
from
January 30, 2025 14:57
758a272
to
0052596
Compare
zzzeid
force-pushed
the
zeid/bug-1944341-legacy-repo-linking
branch
from
January 30, 2025 14:59
0052596
to
c8556f9
Compare
zzzeid
force-pushed
the
zeid/bug-1944341-legacy-repo-linking
branch
from
January 30, 2025 15:00
c8556f9
to
2bcd3f0
Compare
shtrom
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
zzzeid
force-pushed
the
zeid/bug-1944341-legacy-repo-linking
branch
2 times, most recently
from
January 31, 2025 14:27
64ba9d8
to
1bbe90e
Compare
- add Repo.legacy_source - when requesting a landing, detect legacy source repo - redirect landing requests to new target repo - add models - update landing preview modal to show legacy source - move some test fixtures to conftest - add tests - update .gitignore to pick up more files
zzzeid
force-pushed
the
zeid/bug-1944341-legacy-repo-linking
branch
from
January 31, 2025 14:34
1bbe90e
to
b74f143
Compare
shtrom
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions inline.
shtrom
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.