Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: fetch tags when cloning repo (bug 1938436) #214

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Jan 30, 2025

No description provided.

@zzzeid zzzeid force-pushed the zeid/bug-1938436-fix-version branch from a5ab12e to dc48de3 Compare January 30, 2025 19:13
@zzzeid zzzeid force-pushed the zeid/bug-1938436-fix-version branch from dc48de3 to 8ab059f Compare January 30, 2025 20:05
@zzzeid zzzeid marked this pull request as ready for review January 30, 2025 20:06
@zzzeid zzzeid requested review from shtrom and cgsheeh January 30, 2025 20:06
@zzzeid zzzeid changed the title Dockerfile: add generate_version_file command (bug 1938436) workflows: fetch tags when cloning repo (bug 1938436) Jan 30, 2025
@shtrom
Copy link
Member

shtrom commented Jan 30, 2025

LGTM, but the PR description doesn't seem to match the commit's content.

@zzzeid
Copy link
Collaborator Author

zzzeid commented Jan 30, 2025

LGTM, but the PR description doesn't seem to match the commit's content.

Ah, fixed that just before you submitted your comment.

@zzzeid zzzeid merged commit 5f797d9 into main Jan 30, 2025
1 check passed
@zzzeid zzzeid deleted the zeid/bug-1938436-fix-version branch January 30, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants