Suite improvements for new lando (bug 1885346) (bug 1904696) (bug 1920987) #59
Conversation
shtrom
changed the title
shtrom
force-pushed
the
suite-fixups
branch
3 times, most recently
from
df0c3d7 to
23c9272
Compare
shtrom
changed the title
shtrom
force-pushed
the
suite-fixups
branch
2 times, most recently
from
d19531b to
65fe9e4
Compare
Signed-off-by: Olivier Mehani <[email protected]>
Signed-off-by: Olivier Mehani <[email protected]>
Signed-off-by: Olivier Mehani <[email protected]>
* mysqls * phab and bmo * phabricator.test Signed-off-by: Olivier Mehani <[email protected]>
…time This is useful when the target container has been replaced and has a new IP address, but the nginx container still points to the old, cached, IP. Signed-off-by: Olivier Mehani <[email protected]>
Signed-off-by: Olivier Mehani <[email protected]>
…g 1821149) Signed-off-by: Olivier Mehani <[email protected]>
Signed-off-by: Olivier Mehani <[email protected]>
shtrom
force-pushed
the
suite-fixups
branch
2 times, most recently
from
7354c25 to
1d80265
Compare
|
@zzzeid this PR is a combination of
There may be a couple of conflicts when merging back into |
shtrom
changed the title
shtrom
changed the title
Signed-off-by: Olivier Mehani <[email protected]>
Signed-off-by: Olivier Mehani <[email protected]>
Signed-off-by: Olivier Mehani <[email protected]>
Signed-off-by: Olivier Mehani <[email protected]>
Signed-off-by: Olivier Mehani <[email protected]>
docker-compose.yml
Outdated
| lando-init: | ||
| user: "${UID}:${GID}" | ||
| image: mozilla/lando:latest # TODO: this does not exist yet. | ||
| command: lando setup_dev | ||
| env_file: | ||
| - ../lando/.env | ||
| environment: | ||
| <<: *base-lando-vars | ||
| depends_on: | ||
| lando.db: | ||
| condition: service_healthy | ||
| phabricator.test: | ||
| condition: service_healthy | ||
|
|
There was a problem hiding this comment.
As discussed, might be better to include the setup_dev command in the main lando container instead, along with the other development specific commands. Also, this could be combined in the main compose file.
|
Ok, I moved things around, and did some cleanup while I was at it. I added a healthcheck, and needed to add a dependency on phabricator.test before starting lando, as it tries (and fails) to talk to it on start and gets into a restart loop. Starting with the override,
works reliably (but is a bit slow due to the phabricator dep). I tested without the override, by using the |
Signed-off-by: Olivier Mehani <[email protected]>
Also, reorder startup so non-DB commands run first.
No description provided.