-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared tc dir #5
Merged
escapewindow
merged 31 commits into
mozilla-extensions:master
from
escapewindow:shared-tc-dir
Apr 30, 2020
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
939744e
update .taskcluster.yml for shared
escapewindow 14e14c0
nuke taskcluster/
escapewindow 7794c5a
move GITHUB_CLONE_SECRET to .taskcluster.yml
escapewindow 5413569
add new template parameters
escapewindow 2ceb953
fix
escapewindow faa2c7e
to_unicode
escapewindow 68feeb3
try backing out the new params
escapewindow ac74b17
try text_type(...)
escapewindow d69630a
project-regex
escapewindow c19cefb
ugh
escapewindow cd6002c
get env from decision task
escapewindow 82ab504
point at real repo master (commented atm)
escapewindow f7b3f3a
fix githubCloneSecret
escapewindow 6e3938c
use project-regex for xpi
escapewindow 800d4fc
add checkout: to build and test
escapewindow b8b9686
default-repository for xpi-template
escapewindow ca54111
xpi {}
escapewindow 2068ecb
get rid of special template parameter handling
escapewindow 9a2e2ec
fix
escapewindow 0e5a9d7
use --root instead of rm/ln taskcluster
escapewindow 08431f1
back out to ca54111
escapewindow 68d1fb9
re-add parameters.py
escapewindow 7bd92b9
revert back to 0e5a9d7
escapewindow 41b3133
add docker-image kind
escapewindow b744e36
add docker dir
escapewindow d196347
use johan's taskgraph-try 12d2c3fb3c584209b9caef89691e81dbffb8129e
escapewindow 94903b9
0dbd05252def2df5c6b5e3322d196499c61ada5a
escapewindow c511f4e
back out to 9a2e2ec, fix one thing at a time
escapewindow 202ec73
bump to taskgraph c78d65237c6ed064b9cbb3cd063b22e9e052a06a
escapewindow 85da87f
back to b34543ca2f42771117fa9da33c31994913587636
escapewindow dbe107d
c78d65237c6ed064b9cbb3cd063b22e9e052a06a again
escapewindow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not need to do this dance moving around the
taskcluster
directory. You can pass--root path/to/taskcluster/ci
totaskgraph decision
to read from a different location (this is how comm-central handles things).Alternatively, you could run taskgraph from the template repository, with the xpi repository in a known place. (This is closer to what ci-admin/ci-config does, but ci-config isn't even checked out).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this breaks any automation on xpi-template itself, but perhaps we want to turn that off anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it breaks for test-xpi-public as well. I'm guessing --root also keeps us from looking in test-xpi-public for the xpi source, and instead looks in xpi-template ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I was avoiding this, because a) we need to translate paths, and b) xpi-template is level 3; the xpi source repo will be level 1. We could make xpi-template level 1. Is going back to the taskcluster/ dance a blocker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
busted test-xpi-public: mozilla-releng/staging-xpi-public#6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--root
seems to break everything. I'm going to punt on that.