Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo refresh #384

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Logo refresh #384

merged 2 commits into from
Dec 9, 2024

Conversation

bheesham
Copy link
Member

@bheesham bheesham commented Dec 3, 2024

Jira: IAM-1513


Screenshot 2024-12-09 at 10 57 16

@bheesham bheesham requested a review from a team December 3, 2024 16:20
@bheesham
Copy link
Member Author

bheesham commented Dec 3, 2024

For future wanderers: I couldn't get this working natively, so I ran stuff using Docker.

Something along these lines:

docker run -v "$(PWD):/src" -w /src --entrypoint npm -it node:14 install
docker run -v "$(PWD):/src" -w /src -p 3000:3000 --entrypoint npm -it node:14 run watch
# Open your browser and go to http://localhost:3000/

I'm open to adding this stuff to the documentation, but before that I'd like trying to upgrade deps, etc, etc and get it working without a workaround.

@dividehex
Copy link
Contributor

Nice work. The "Mozilla" word logo also needs to be updated. see https://brand.mozilla.com for guide lines and image assets.

Jira: IAM-1513
@bheesham
Copy link
Member Author

bheesham commented Dec 9, 2024

Nice work. The "Mozilla" word logo also needs to be updated. see https://brand.mozilla.com for guide lines and image assets.

Done! I updated the screenshot in the PR description to match.

@bheesham bheesham requested a review from dividehex December 9, 2024 16:00
Copy link
Contributor

@dividehex dividehex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Approved

@bheesham bheesham merged commit e674845 into mozilla-iam:master Dec 9, 2024
1 check passed
@bheesham bheesham deleted the change-logo branch December 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants