hide tips and tricks when help sheets are enabled (#8996)

mozilla-mobile · Jan 23, 2024 · 885976a · 885976a
1 parent 3138244
commit 885976a
Showing 1 changed file with 23 additions and 9 deletions.
diff --git a/src/ui/screens/settings/ViewSettingsMenu.qml b/src/ui/screens/settings/ViewSettingsMenu.qml
@@ -92,15 +92,29 @@ MZViewBase {
                 visible: MZFeatureList.get("splitTunnel").isSupported
             }
 
-            MZSettingsItem {
-                objectName: "settingsTipsAndTricks"
-                settingTitle: MZI18n.SettingsTipsAndTricksSettings
-                imageLeftSrc: "qrc:/ui/resources/settings/tipsandtrickssettings.svg"
-                imageRightSrc: "qrc:/nebula/resources/chevron.svg"
-                imageRightMirror: MZLocalizer.isRightToLeft
-                onClicked: {
-                    Glean.interaction.tipsAndTricksSelected.record({screen:telemetryScreenId})
-                    MZNavigator.requestScreen(VPN.ScreenTipsAndTricks);
+            Loader {
+                Layout.preferredHeight: item.Layout.preferredHeight
+                Layout.fillWidth: item.Layout.fillWidth
+
+                visible: active
+                active: !MZFeatureList.get("helpSheets").isSupported
+
+                sourceComponent: MZSettingsItem {
+                    objectName: "settingsTipsAndTricks"
+
+                    anchors.right: parent.right
+                    anchors.left: parent.left
+                    anchors.leftMargin: 0
+                    anchors.rightMargin: 0
+
+                    settingTitle: MZI18n.SettingsTipsAndTricksSettings
+                    imageLeftSrc: "qrc:/ui/resources/settings/tipsandtrickssettings.svg"
+                    imageRightSrc: "qrc:/nebula/resources/chevron.svg"
+                    imageRightMirror: MZLocalizer.isRightToLeft
+                    onClicked: {
+                        Glean.interaction.tipsAndTricksSelected.record({screen:telemetryScreenId})
+                        MZNavigator.requestScreen(VPN.ScreenTipsAndTricks);
+                    }
                 }
             }