VPN-4227: Windows daemon recovery on crash #9214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskirby
force-pushed
the
vpn-4227-windows-daemon-recovery
branch
from
f253ca2 to
b453ded
Compare
mcleinman
reviewed
Mar 6, 2024
There was a problem hiding this comment.
This look reasonable, but I'm not familiar with our Windows networking code. I don't feel comfortable approving this without asking a lot of questions so I come up to speed in this area.
If @lesleyjanenorton is not comfortable approving, let me know and I'll ask questions here or set up some time to walk through it with you.
|
@mcleinman in light of the recent staffing changes, I think I am probably the only Windows networking expert on the team. Please feel free to ask questions. |
mcleinman
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to add a bit more robustness to the VPN client, we should ensure we can recovery gracefully in the event of a crash of the daemon. This adds some handling of unexpected daemon termination and takes steps to ensure that the system remains in a usable state even if a crash occurs.
Reference
Github issue #7986 (VPN-4227)
Github issue #7987 (VPN-4231)
Checklist