Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use simple-github for detecting branches #104

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ahal
Copy link
Contributor

@ahal ahal commented Sep 18, 2024

This allows us to use app auth in addition to token auth.

This allows us to use app auth in addition to token auth.
@ahal ahal requested a review from bhearsum September 18, 2024 17:23
@ahal ahal self-assigned this Sep 18, 2024
@ahal ahal requested a review from a team as a code owner September 18, 2024 17:23
@ahal
Copy link
Contributor Author

ahal commented Sep 18, 2024

I realize that this isn't really simplifying much. I'm mostly doing this because I want to stand up some automation that will require auth here, and I want to stop relying on the moz-automation Github accounts and start using app auth for everything instead.

@ahal
Copy link
Contributor Author

ahal commented Sep 18, 2024

Also I filed mozilla-releng/simple-github#49 to add implicit support for pagination in simple-github. It'll get there eventually :p

Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this enhancement/follow-up. Consider updating the GITHUB_TOKEN warning to also mention app configuration. (I could go either way on this...it's not something someone is likely to use locally, but I suppose it could conceivably come up in some future CI configuration.)

@ahal
Copy link
Contributor Author

ahal commented Sep 18, 2024

Thanks, I think app auth is complicated enough that it'll probably just add confusion. I think we should just omit it from the warning.

@ahal ahal merged commit a8ccc29 into mozilla-releng:main Sep 18, 2024
8 checks passed
@ahal ahal deleted the simple_github branch September 18, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants