Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implementation for win alpha builders to fix runTasksAsCurrent… #301

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

jwmoss
Copy link
Contributor

@jwmoss jwmoss commented Feb 26, 2025

…User

@jwmoss jwmoss requested review from a team as code owners February 26, 2025 20:50
@jcristau
Copy link
Contributor

Something like this should work:

diff --git a/worker-pools.yml b/worker-pools.yml
index 5668aea..4245553 100644
--- a/worker-pools.yml
+++ b/worker-pools.yml
@@ -2562,33 +2562,32 @@ pools:
   # Windows 11
   - pool_id: '{pool-group}/win11-a64-24h2-builder-{suffix}'
     description: ''
     owner: [email protected]
     email_on_error: true
     attributes:
       suffix: ''
       level: 1
+      implementation: generic-worker/worker-runner-windows
     variants:
       - pool-group: gecko-1
       - pool-group: gecko-3
         level: 3
       - pool-group: gecko-1
         suffix: alpha
+        implementation: generic-worker/windows
       - pool-group: mozillavpn-1
     provider_id:
       by-level:
         1: azure2
         3: azure_trusted
     config:
       image: 'ronin_b{level}_windows11_a64_24h2_builder_{suffix}'
-      implementation:
-        by-suffix:
-          .*alpha: generic-worker/windows
-          default: generic-worker/worker-runner-windows
+      implementation: '{implementation}'
       worker-purpose:
         by-pool-group:
           mozillavpn-1: vpn-1
           default: null  # defaults to pool-group
       locations: [east-us-2, west-us-3, north-central-us, central-us]
       maxCapacity:
         by-pool-group:
           gecko.*: 250

@jwmoss jwmoss enabled auto-merge (squash) February 27, 2025 13:09
Copy link
Contributor

@rcurranmoz rcurranmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jwmoss jwmoss merged commit 95943a2 into main Feb 27, 2025
7 checks passed
@jwmoss jwmoss deleted the relops-1329 branch February 27, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants