Skip to content

Commit

Permalink
Remove Dead Crash Client (#5143)
Browse files Browse the repository at this point in the history
* Enable the crashreporting screen for sentry

* Remove Old-CrashClient

* revert rebase fails

* remove crash report stuff
  • Loading branch information
strseb authored Jan 12, 2023
1 parent a44cd82 commit 0af0573
Show file tree
Hide file tree
Showing 30 changed files with 0 additions and 1,029 deletions.
4 changes: 0 additions & 4 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ target_compile_definitions(mozillavpn PRIVATE "$<$<CONFIG:Debug>:MZ_DEBUG>")
target_compile_definitions(mozillavpn PRIVATE "MZ_$<UPPER_CASE:${MZ_PLATFORM_NAME}>")
include(apps/vpn/cmake/${MZ_PLATFORM_NAME}.cmake)

if(NOT ${CMAKE_SYSTEM_NAME} STREQUAL "Emscripten")
add_subdirectory(apps/vpn/crashreporter)
target_link_libraries(mozillavpn PRIVATE crashreporter)
endif()

if(NOT CMAKE_CROSSCOMPILING)
target_compile_definitions(mozillavpn PUBLIC MVPN_WEBEXTENSION)
Expand Down
2 changes: 0 additions & 2 deletions src/apps/vpn/cmake/windows.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ target_sources(mozillavpn PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/version.rc)

# Windows platform source files
target_sources(mozillavpn PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/apps/vpn/commands/commandcrashreporter.cpp
${CMAKE_CURRENT_SOURCE_DIR}/apps/vpn/commands/commandcrashreporter.h
${CMAKE_CURRENT_SOURCE_DIR}/apps/vpn/daemon/daemon.cpp
${CMAKE_CURRENT_SOURCE_DIR}/apps/vpn/daemon/daemon.h
${CMAKE_CURRENT_SOURCE_DIR}/apps/vpn/daemon/daemonlocalserver.cpp
Expand Down
27 changes: 0 additions & 27 deletions src/apps/vpn/commands/commandcrashreporter.cpp

This file was deleted.

18 changes: 0 additions & 18 deletions src/apps/vpn/commands/commandcrashreporter.h

This file was deleted.

43 changes: 0 additions & 43 deletions src/apps/vpn/crashreporter/CMakeLists.txt

This file was deleted.

5 changes: 0 additions & 5 deletions src/apps/vpn/crashreporter/crash_resources.qrc

This file was deleted.

23 changes: 0 additions & 23 deletions src/apps/vpn/crashreporter/crashclient.cpp

This file was deleted.

22 changes: 0 additions & 22 deletions src/apps/vpn/crashreporter/crashclient.h

This file was deleted.

31 changes: 0 additions & 31 deletions src/apps/vpn/crashreporter/crashreporter.cpp

This file was deleted.

37 changes: 0 additions & 37 deletions src/apps/vpn/crashreporter/crashreporter.h

This file was deleted.

38 changes: 0 additions & 38 deletions src/apps/vpn/crashreporter/crashreporter.pri

This file was deleted.

24 changes: 0 additions & 24 deletions src/apps/vpn/crashreporter/crashreporterapp.cpp

This file was deleted.

14 changes: 0 additions & 14 deletions src/apps/vpn/crashreporter/crashreporterapp.h

This file was deleted.

22 changes: 0 additions & 22 deletions src/apps/vpn/crashreporter/crashreporterfactory.cpp

This file was deleted.

18 changes: 0 additions & 18 deletions src/apps/vpn/crashreporter/crashreporterfactory.h

This file was deleted.

11 changes: 0 additions & 11 deletions src/apps/vpn/crashreporter/crashresources/Warning.svg

This file was deleted.

7 changes: 0 additions & 7 deletions src/apps/vpn/crashreporter/crashserverclient.cpp

This file was deleted.

14 changes: 0 additions & 14 deletions src/apps/vpn/crashreporter/crashserverclient.h

This file was deleted.

Loading

1 comment on commit 0af0573

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

["assume:repo:github.com/mozilla-releng/staging-mozilla-vpn-client:release:published","queue:route:checks","queue:scheduler-id:taskcluster-github"]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

assume:repo:github.com/mozilla-releng/staging-mozilla-vpn-client:release

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "assume:repo:github.com/mozilla-releng/staging-mozilla-vpn-client:release",
    "queue:route:checks",
    "queue:create-task:project:none",
    "queue:scheduler-id:mozillavpn-level-1",
    {
      "AnyOf": [
        "queue:create-task:highest:mozillavpn-1/decision-gcp",
        "queue:create-task:very-high:mozillavpn-1/decision-gcp",
        "queue:create-task:high:mozillavpn-1/decision-gcp",
        "queue:create-task:medium:mozillavpn-1/decision-gcp",
        "queue:create-task:low:mozillavpn-1/decision-gcp",
        "queue:create-task:very-low:mozillavpn-1/decision-gcp",
        "queue:create-task:lowest:mozillavpn-1/decision-gcp"
      ]
    }
  ]
}

  • method: createTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-01-12T19:48:04.643Z

Please sign in to comment.