Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISCO-3254] [load test: abort] Bump Python version to 3.13 #799

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DISCO-3254] [load test: abort] Bump Python version to 3.13 #799

wants to merge 1 commit into from

Conversation

Herraj
Copy link
Contributor

@Herraj Herraj commented Feb 19, 2025 •
edited
Loading

References

JIRA: DISCO-3254

Description

Bumping the python version 3.12 --> 3.13.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

@Herraj Herraj self-assigned this Feb 19, 2025
@Herraj Herraj marked this pull request as draft February 19, 2025 19:46
Trinaa
Trinaa reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@Trinaa Trinaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why opt out of the load test? The load test Dockerfile is being upgraded, seems prudent to run it.

@Herraj
Copy link
Contributor Author

Herraj commented Feb 20, 2025

Why opt out of the load test? The load test Dockerfile is being upgraded, seems prudent to run it.

I have it as abort 🤔 Want the deployment to stop if anything goes wrong during the load test. Is using warn a better approach here?

@Trinaa
Copy link
Contributor

Trinaa commented Feb 20, 2025

Sorry @Herraj, disregard my comment abort is great, for some reason i interpreted it as skip.

@Herraj Herraj added the do not merge Do not merge even if approved label Feb 25, 2025
@Herraj Herraj force-pushed the disco-3254-bump-python-version-to-3.13 branch from 4723dba to 7469dbd Compare February 25, 2025 19:49
@Herraj Herraj force-pushed the disco-3254-bump-python-version-to-3.13 branch from 7469dbd to 43ebc4b Compare February 25, 2025 20:24
@Herraj Herraj marked this pull request as ready for review February 25, 2025 20:35
@Herraj Herraj requested a review from a team February 25, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trinaa Trinaa Trinaa left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Herraj Herraj

Labels
do not merge Do not merge even if approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Herraj @Trinaa