[DISCO-3247] fix: weather pathfinder to use region when None #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiftran
commented
Feb 19, 2025
| @@ -66,109 +66,31 @@ def test_compass(location: Location, expected_region_and_city: str) -> None: | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
| ("weather_context", "expected_calls"), | |||
There was a problem hiding this comment.
I removed the actual list of weather contexts, as it only returns the state of the weather context after all the calls and it's actually not useful
ncloudioj
approved these changes
Feb 20, 2025
merino/providers/suggest/weather/backends/accuweather/pathfinder.py
Outdated
Show resolved
Hide resolved
tiftran
force-pushed
the
bug-no-region
branch
2 times, most recently
from
056ce44 to
aa903c8
Compare
…er.py Co-authored-by: Nan Jiang <[email protected]>
tiftran
force-pushed
the
bug-no-region
branch
from
aa903c8 to
35973f9
Compare
tiftran
force-pushed
the
bug-no-region
branch
from
b4e7cd2 to
f38b185
Compare
tiftran
commented
Feb 20, 2025
| @@ -729,7 +729,7 @@ async def get_location_by_geolocation( | |||
| """ | |||
| geolocation = weather_context.geolocation | |||
| country = geolocation.country | |||
| city = geolocation.city | |||
| city = weather_context.selected_city | |||
There was a problem hiding this comment.
realized we still had weird behaviour because selected_city wasn't used in the actual api call
ncloudioj
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3247
Description
We tried to be fancy and it sort of bit us. We can't iterate over a map twice, so I swapped the two for loops. so we can keep map. In theory there's only a small number of edge cases where the first iteration is not successful and we would have more iterations then if the for loop order was swapped
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)