[DISCO-3134] Fix Test Artifacts Upload to GCS on Failure #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uploading test artifacts using the 'upload-test-artifacts' job will not work should one of its dependent test jobs fail. This fix uses a step with the directive to run 'when: always' to assure artifact upload. Relates To: DISCO-3134
Herraj
approved these changes
Feb 21, 2025
| - upload_to_gcs: | ||
| source: workspace/test-results | ||
| destination: gs://ecosystem-test-eng-metrics/merino-py/coverage | ||
| extension: json |
There was a problem hiding this comment.
okay to have the same name for both steps?
There was a problem hiding this comment.
ah I see it takes parameters, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3134
Description
Uploading test artifacts using the 'upload-test-artifacts' job will not work should one of its dependent test jobs fail. This fix uses a step with the directive to run 'when: always' to assure artifact upload.
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)