Refactor promoted groups to use APIChoicesWithNone #23051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
force-pushed
the
kevinmind/addons/14986-add-promoted-group-model
branch
8 times, most recently
from
981884d to
a9c3e9b
Compare
KevinMind
force-pushed
the
kevinmind/addons/14986-add-promoted-group-model
branch
2 times, most recently
from
8a251ab to
3c7abc4
Compare
KevinMind
commented
Feb 4, 2025
KevinMind
force-pushed
the
kevinmind/addons/14986-add-promoted-group-model
branch
2 times, most recently
from
9052755 to
2358f05
Compare
- Replacing hardcoded promoted group constants with an APIChoicesWithNone implementation - Updating references across multiple files to use the new PROMOTED_GROUP_CHOICES - Ensuring consistent group ID references and API-related attributes - Simplifying imports and reducing redundant constant definitions The changes improve type safety, make the code more maintainable, and provide a more flexible approach to managing promoted addon groups.
KevinMind
force-pushed
the
kevinmind/addons/14986-add-promoted-group-model
branch
from
2358f05 to
b350cd3
Compare
KevinMind
changed the title
chrstinalin
reviewed
Feb 7, 2025
chrstinalin
reviewed
Feb 7, 2025
chrstinalin
reviewed
Feb 7, 2025
chrstinalin
approved these changes
Feb 7, 2025
KevinMind
deleted the
kevinmind/addons/14986-add-promoted-group-model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: mozilla/addons#15335
Description
Context
This is a step to simplifying the PromotedAddon data model by isolating the PromotedClass instances. If we don't import them all over the code base we can more easily make changes to the data model without breaking things.
Testing
CI should pass, no changes to any logic, just string/number references.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.