MNTOR-3902 - Design changes to monthly report emails #5530
Merged
+153
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5530-mgjlpikfea-uk.a.run.app |
codemist
requested review from
flozia and
Vinnl
and removed request for
flodolo
flozia
approved these changes
Jan 28, 2025
| @@ -9,7 +9,7 @@ import { ReactNode } from "react"; | |||
| // to avoid this error: | |||
| // > Uncaught ReferenceError: MessageChannel is not defined | |||
| // See https://github.com/facebook/react/issues/31827#issuecomment-2563094822 | |||
| import { renderToStaticMarkup } from "react-dom/server.edge"; | |||
| import { renderToStaticMarkup } from "react-dom/server"; | |||
There was a problem hiding this comment.
Question: Was this supposed to be changed back to import { renderToStaticMarkup } from "react-dom/server.edge";?
There was a problem hiding this comment.
No, it should be .edge, I just removed it to be able to test on storybook.
|
Cleanup completed - database 'blurts-server-pr-5530' destroyed, cloud run service 'blurts-server-pr-5530' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3902
Figma: https://www.figma.com/design/Z7pfHXJTSG5Szm3UrkYsVx/Emails-v2.0?node-id=1086-21087&t=wfCPYxaRZjomm7mv-0
Description
Adds UI updates to the Monthly free activity email.
Storybook previews don't seem to be working, due to the React upgrade (thread can be found here)
To test locally, remove
.edgefrom theimport { renderToStaticMarkup } from "react-dom/server.edge"import line inStorybookEmailRenderer.tsxto be able to see the story previews.Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)