Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add example Nimbus feature for testing #5595

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

rhelmer
Copy link
Collaborator

@rhelmer rhelmer commented Feb 5, 2025

References:

Description

The Nimbus team has asked us to re-introduce the "example" feature to use for testing purposes.

We do not need to use this from the code, it just needs to be present in the nimbus.yaml (aka feature manifest list or FML)

Checklist (Definition of Done)

@rhelmer rhelmer requested a review from mansaj February 5, 2025 21:30
@rhelmer rhelmer self-assigned this Feb 5, 2025
Copy link

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me 👍

Copy link

github-actions bot commented Feb 5, 2025

@rhelmer rhelmer requested a review from jaredlockhart February 5, 2025 21:45
@rhelmer
Copy link
Collaborator Author

rhelmer commented Feb 5, 2025

This looks correct to me 👍

Thanks @jaredlockhart - our linter caught the fact that I needed to update the channel names, so that's now fixed.

@rhelmer rhelmer merged commit 2140011 into main Feb 5, 2025
16 checks passed
@rhelmer rhelmer deleted the re-add-nimbus-example-feature branch February 5, 2025 22:03
Copy link

github-actions bot commented Feb 5, 2025

Cleanup completed - database 'blurts-server-pr-5595' destroyed, cloud run service 'blurts-server-pr-5595' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants