Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Make id field customizable #272

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

toopy
Copy link

@toopy toopy commented Oct 27, 2014

Then developper can define which field to use as index key in a convenient way.

@willkg
Copy link
Member

willkg commented Oct 27, 2014

This needs:

  1. git commit messages that are formatted correctly (http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
  2. the commits should be squashed--this is really one single change
  3. the commit should refer to issue The name of the primary key is hardcoded #265 which this fixes
  4. this needs unit tests

I'll look at it after that's done.

@toopy toopy force-pushed the make-id_field-customizable branch 2 times, most recently from aa6a0fb to ba5bbb2 Compare November 4, 2014 07:29
@toopy
Copy link
Author

toopy commented Nov 5, 2014

up

@louiseGrandjonc
Copy link

Hello, is it possible to merge that PR because I'm using it and it's very usefull 👍

Bye

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants