Merge branch 'release-v0.17.0' into release

mozilla · Jul 16, 2021 · 14af0bf · 14af0bf
2 parents 1cfdb5a + fede13f
commit 14af0bf
Show file tree

Hide file tree

Showing 28 changed files with 1,514 additions and 741 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -132,7 +132,7 @@ jobs:
             source venv/bin/activate
             pip install -r requirements.txt
             glean_parser translate metrics.yaml pings.yaml -f javascript -o generated \
-            --option platform=qt --option version="0.16"
+            --option platform=qt --option version="0.17"
 
             sudo apt-get install xvfb
             xvfb-run python main.py &> qml.log &

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 # Unreleased changes
 
-[Full changelog](https://github.com/mozilla/glean.js/compare/v0.16.0...main)
+[Full changelog](https://github.com/mozilla/glean.js/compare/v0.17.0...main)
+
+# v0.17.0 (2021-07-16)
+
+[Full changelog](https://github.com/mozilla/glean.js/compare/v0.16.0...v0.17.0)
+
+* [#529](https://github.com/mozilla/glean.js/pull/529): Implement the URL metric type.
 
 # v0.16.0 (2021-07-06)
 

diff --git a/benchmarks/size/webext/max.js b/benchmarks/size/webext/max.js
@@ -13,6 +13,7 @@ import QuantityMetricType from "@mozilla/glean/webext/private/metrics/quantity";
 import StringMetricType from "@mozilla/glean/webext/private/metrics/string";
 import TimespanMetricType from "@mozilla/glean/webext/private/metrics/timespan";
 import UUIDMetricType from "@mozilla/glean/webext/private/metrics/uuid";
+import URLMetricType from "@mozilla/glean/webext/private/metrics/url";
 // Plugins
 import PingEncryptionPlugin from "@mozilla/glean/webext/plugins/encryption";
 
@@ -29,5 +30,6 @@ console.log(
   JSON.stringify(StringMetricType),
   JSON.stringify(TimespanMetricType),
   JSON.stringify(UUIDMetricType),
+  JSON.stringify(URLMetricType),
   JSON.stringify(PingEncryptionPlugin),
 );
diff --git a/docs/adding_a_new_metric_type.md b/docs/adding_a_new_metric_type.md
@@ -169,6 +169,9 @@ async function testGetValue(ping: string = this.sendInPings[0]): Promise<string
 
 > **Note**: All testing functions must start with the prefix `test`.
 
+The `testGetNumRecordedErrors` function does not need to be implemeted individually per metric
+type as it is already implemented on the `MetricType` super class.
+
 ## Testing
 
 Tests for metric type implementations live under the `glean/tests/unit/core/metrics/types` folder. Create a new