Urls redux #5978
Open
Urls redux #5978
+122
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix URLs * Fix where URLs are imported * Fix tests everywhere
|
This involved a lot of test changes, so warrants pretty close inspection. |
akatsoulas
approved these changes
May 1, 2024
|
Please do not merge - I am having another pass |
akatsoulas
requested changes
May 1, 2024
| @@ -463,6 +463,7 @@ def immutable_file_test(path, url): | |||
| }, | |||
| ] | |||
|
|
|||
| APPEND_SLASH = True | |||
| @@ -38,14 +38,14 @@ def test_visit_count_from_analytics(self, _build_request, close_old_connections) | |||
| PAGEVIEWS_BY_DOCUMENT_RESPONSE = { | |||
| "kind": "analytics#gaData", | |||
| "rows": [ | |||
| ["/en-US/kb/hellỗ", "27"], | |||
There was a problem hiding this comment.
Let's update the urls per app. One PR for one app and avoid adding multiple commits per app
There was a problem hiding this comment.
I'd ask you to reconsider - this is a test in dashboards that fails because of a setting change in the wiki urls .
This PR is for wiki url changes, and fixing what those changes break, which is tests in a four other apps. You need the wiki/urls.py changes in place so your changed tests will work.
| @@ -192,11 +192,11 @@ def test_internal_links(self): | |||
| # Both internal links should link to the same article | |||
| self.assertEqual( | |||
| p.parse("[[%s]]" % doc.title), | |||
| '<p><a href="/en-US/kb/%s">%s</a>\n</p>' % (doc.slug, doc.title), | |||
There was a problem hiding this comment.
why does this need changing?
There was a problem hiding this comment.
Because
'<p><a href="/en-US/kb/real-article/">Real article</a>\n</p>' != '<p><a href="/en-US/kb/real-article">Real article</a>\n</p>'
- <p><a href="/en-US/kb/real-article/">Real article</a>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate URL warning/error spam at Django startup.