Allow same names for dimensions and time dimension groups in generated views #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akkomar
force-pushed
the
time_dimensions
branch
2 times, most recently
from
d972d4c to
e897c0d
Compare
akkomar
commented
Jul 16, 2024
Comment on lines
-129
to
-131
| and not (name == "event" and dimension["type"] == "time") | ||
| # workaround for `mozdata.firefox_desktop.desktop_installs` | ||
| and not (name == "attribution_dltoken" and dimension["type"] == "time") |
There was a problem hiding this comment.
We no longer need these workarounds now.
sean-rose
approved these changes
Jul 17, 2024
generator/views/lookml_utils.py
Outdated
Comment on lines
161
to
163
| and dimension["name"] != "submission" | ||
| and not dimension["name"].endswith("end") | ||
| and not dimension["name"].endswith("start") |
There was a problem hiding this comment.
Same here.
It seems like it'd be good to refactor this repeated logic in _generate_dimensions and _generate_dimensions_from_query out into a separate function named something like _generate_dimensions_from_schema. The only catch is the exception messages for duplicate dimensions are different, and in _generate_dimensions it does helpfully include the table in the error message, but for that case you could probably wrap the _generate_dimensions_from_schema call in a try/catch and do something like
raise click.ClickException(f"Error generating dimensions for table {table!r}") from e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1007 that would fix mozilla/bigquery-etl#5903, implements suggestion from #1007 (comment).
This approach seems to be minimally invasive and generalized, without hardcoding table names, allowing to unblock mozilla/bigquery-etl#5903.