-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Windows bindings for required symbols only #14
Conversation
99af81c
to
2584091
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 94.55% 93.06% -1.49%
==========================================
Files 1 1
Lines 202 202
==========================================
- Hits 191 188 -3
- Misses 11 14 +3 ☔ View full report in Codecov by Sentry. |
Should we exclude the bindings file from coverage checking? |
Yes, that probably makes sense. How do you want to do this? |
Change |
Thanks! |
This avoids pulling in all of windows-sys and windows (even if most parts are excluded via Cargo features). The windows crate contains 9+ MB of code, so IMO avoiding that makes sense for a low-level/small crate like this.