-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
family takes values based on IP type #71
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 86.46% 86.28% -0.19%
==========================================
Files 5 5
Lines 554 554
Branches 554 554
==========================================
- Hits 479 478 -1
- Misses 47 48 +1
Partials 28 28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
Why did the codecov/project check fail? |
There is one line it claims it's not seeing coverage for anymore: https://app.codecov.io/gh/mozilla/mtu/pull/71?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=mozilla#0d46108ce4a3c312f023e721b094d40c-L111 That is likely wrong, or at least I don't think we hit that error condition before either. Codecov sometimes has discrepancies like that. |
May I ask why this PR was closed? |
Sorry!! I meant to merge this. I think I need more coffee. |
Thanks again for your contribution. Please let us know if there are other issues. |
On Windows, IPv6 and IPv4 can have different MTU values.