feat: Extend Frame::Padding with length (#1762)
#2010
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: CI | |
| on: | |
| push: | |
| branches: ["main"] | |
| paths-ignore: ["*.md", "*.png", "*.svg", "LICENSE-*"] | |
| pull_request: | |
| branches: ["main"] | |
| paths-ignore: ["*.md", "*.png", "*.svg", "LICENSE-*"] | |
| merge_group: | |
| env: | |
| CARGO_TERM_COLOR: always | |
| RUST_BACKTRACE: 1 | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref_name }} | |
| cancel-in-progress: true | |
| jobs: | |
| check: | |
| name: Build & test | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| os: [ubuntu-latest, macos-14, windows-latest] | |
| # Don't increase beyond what Firefox is currently using: | |
| # https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html#schedule | |
| rust-toolchain: [1.74.0, stable, nightly] | |
| type: [debug] | |
| include: | |
| - os: ubuntu-latest | |
| rust-toolchain: stable | |
| type: release | |
| env: | |
| BUILD_TYPE: ${{ matrix.type == 'release' && '--release' || '' }} | |
| runs-on: ${{ matrix.os }} | |
| defaults: | |
| run: | |
| shell: bash | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: Install dependencies (Linux) | |
| if: runner.os == 'Linux' | |
| env: | |
| DEBIAN_FRONTEND: noninteractive | |
| run: | | |
| sudo apt-get install -y --no-install-recommends gyp mercurial ninja-build lld | |
| echo "RUSTFLAGS=-C link-arg=-fuse-ld=lld" >> "$GITHUB_ENV" | |
| # In addition to installing dependencies, first make sure System Integrity Protection (SIP) | |
| # is disabled on this MacOS runner. This is needed to allow the NSS libraries to be loaded | |
| # from the build directory and avoid various other test failures. This seems to always be | |
| # the case on any macos-13 runner, but not consistently on macos-latest (which is currently | |
| # macos-12, FWIW). | |
| - name: Install dependencies (MacOS) | |
| if: runner.os == 'MacOS' | |
| run: | | |
| csrutil status | grep disabled | |
| brew install ninja mercurial llvm | |
| echo "/opt/homebrew/opt/llvm/bin" >> "$GITHUB_PATH" | |
| ln -s /opt/homebrew/bin/python3 /opt/homebrew/bin/python | |
| # python3 -m pip install gyp-next | |
| # Above does not work, since pypi only has gyp 0.15.0, which is too old | |
| # for the homebrew python3. Install from source instead. | |
| python3 -m pip install git+https://github.com/nodejs/gyp-next | |
| python3 -m pip install packaging | |
| echo "$(python3 -m site --user-base)/bin" >> "$GITHUB_PATH" | |
| echo "RUSTFLAGS=-C link-arg=-fuse-ld=lld" >> "$GITHUB_ENV" | |
| - name: Use MSYS2 environment and install more dependencies (Windows) | |
| if: runner.os == 'Windows' | |
| run: | | |
| # shellcheck disable=SC2028 | |
| { | |
| echo "C:\\msys64\\usr\\bin" | |
| echo "C:\\msys64\\mingw64\\bin" | |
| } >> "$GITHUB_PATH" | |
| /c/msys64/usr/bin/pacman -S --noconfirm nsinstall | |
| python3 -m pip install git+https://github.com/nodejs/gyp-next | |
| echo "$(python3 -m site --user-base)/bin" >> "$GITHUB_PATH" | |
| - name: Set up MSVC build environment (Windows) | |
| if: runner.os == 'Windows' | |
| uses: ilammy/msvc-dev-cmd@v1 | |
| - name: Set up NSS/NSPR build environment (Windows) | |
| if: runner.os == 'Windows' | |
| run: | | |
| { | |
| echo "GYP_MSVS_OVERRIDE_PATH=$VSINSTALLDIR" | |
| echo "GYP_MSVS_VERSION=2022" | |
| echo "BASH=$SHELL" | |
| } >> "$GITHUB_ENV" | |
| # See https://github.com/ilammy/msvc-dev-cmd#name-conflicts-with-shell-bash | |
| rm /usr/bin/link.exe | |
| - name: Install Rust | |
| uses: ./.github/actions/rust | |
| with: | |
| version: ${{ matrix.rust-toolchain }} | |
| components: rustfmt, clippy, llvm-tools-preview | |
| - name: Fetch and build NSS and NSPR | |
| uses: ./.github/actions/nss | |
| - name: Build | |
| run: | | |
| # shellcheck disable=SC2086 | |
| cargo +${{ matrix.rust-toolchain }} build $BUILD_TYPE --all-targets --features ci | |
| - name: Run tests and determine coverage | |
| run: | | |
| # shellcheck disable=SC2086 | |
| cargo +${{ matrix.rust-toolchain }} llvm-cov nextest $BUILD_TYPE --all-targets --features ci --no-fail-fast --lcov --output-path lcov.info | |
| cargo +${{ matrix.rust-toolchain }} bench --features bench --no-run | |
| - name: Run client/server transfer | |
| run: | | |
| # shellcheck disable=SC2086 | |
| cargo +${{ matrix.rust-toolchain }} build $BUILD_TYPE --bin neqo-client --bin neqo-server | |
| "target/$BUILD_DIR/neqo-server" "$HOST:4433" & | |
| PID=$! | |
| # Give the server time to start. | |
| sleep 1 | |
| "target/$BUILD_DIR/neqo-client" --output-dir . "https://$HOST:4433/$SIZE" | |
| kill $PID | |
| [ "$(wc -c <"$SIZE")" -eq "$SIZE" ] || exit 1 | |
| env: | |
| HOST: localhost | |
| SIZE: 54321 | |
| RUST_LOG: warn | |
| BUILD_DIR: ${{ matrix.type == 'release' && 'release' || 'debug' }} | |
| - name: Check formatting | |
| run: | | |
| if [ "${{ matrix.rust-toolchain }}" != "nightly" ]; then | |
| CONFIG_PATH="--config-path=$(mktemp)" | |
| fi | |
| # shellcheck disable=SC2086 | |
| cargo +${{ matrix.rust-toolchain }} fmt --all -- --check $CONFIG_PATH | |
| if: success() || failure() | |
| - name: Clippy | |
| run: | | |
| # Use cargo-hack to run clippy on each crate individually with its | |
| # respective default features only. Can reveal warnings otherwise | |
| # hidden given that a plain cargo clippy combines all features of the | |
| # workspace. See e.g. https://github.com/mozilla/neqo/pull/1695. | |
| cargo +${{ matrix.rust-toolchain }} hack clippy --all-targets -- -D warnings || ${{ matrix.rust-toolchain == 'nightly' }} | |
| if: success() || failure() | |
| - name: Check rustdoc links | |
| run: cargo +${{ matrix.rust-toolchain }} doc --workspace --no-deps --document-private-items | |
| env: | |
| RUSTDOCFLAGS: "--deny rustdoc::broken_intra_doc_links --deny warnings" | |
| if: success() || failure() | |
| - name: Upload coverage reports to Codecov | |
| uses: codecov/codecov-action@v4 | |
| with: | |
| file: lcov.info | |
| fail_ci_if_error: false | |
| token: ${{ secrets.CODECOV_TOKEN }} | |
| if: matrix.type == 'debug' && matrix.rust-toolchain == 'stable' | |
| bench: | |
| name: "Benchmark" | |
| needs: [check] | |
| uses: ./.github/workflows/bench.yml |