Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Benchmark NewReno and Cubic #1732

Closed
wants to merge 25 commits into from
Closed

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (bc262a5) to head (f50f414).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1732   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files         124      124           
  Lines       38889    38889           
=======================================
  Hits        34768    34768           
  Misses       4121     4121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/bench.yml Outdated Show resolved Hide resolved
.github/workflows/bench.yml Outdated Show resolved Hide resolved
.github/workflows/bench.yml Outdated Show resolved Hide resolved
.github/workflows/bench.yml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 12, 2024

QUIC Interop Runner

Saving logs to logs.
Run took 0:03:28.365048
Server: neqo-latest. Client: neqo-latest. Running test case: handshake
Server: quic-go. Client: neqo-latest. Running test case: handshake
Server: ngtcp2. Client: neqo-latest. Running test case: handshake
Server: neqo. Client: neqo-latest. Running test case: handshake
Server: msquic. Client: neqo-latest. Running test case: handshake
Server: neqo-latest. Client: quic-go. Running test case: handshake
Server: neqo-latest. Client: ngtcp2. Running test case: handshake
Server: neqo-latest. Client: neqo. Running test case: handshake
Server: neqo-latest. Client: msquic. Running test case: handshake
+-------------+-------------+---------+--------+------+--------+
|             | neqo-latest | quic-go | ngtcp2 | neqo | msquic |
+-------------+-------------+---------+--------+------+--------+
| neqo-latest |     ✓(H)    |   ✓(H)  |  ✓(H)  | ✓(H) |  ✓(H)  |
|             |     ?()     |   ?()   |  ?()   | ?()  |  ?()   |
|             |     ✕()     |   ✕()   |  ✕()   | ✕()  |  ✕()   |
+-------------+-------------+---------+--------+------+--------+
|   quic-go   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|    ngtcp2   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|     neqo    |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|    msquic   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+

⬇️ Download logs

Copy link

github-actions bot commented Mar 12, 2024

Benchmark results

Performance differences relative to 2750423.

  • coalesce_acked_from_zero 1+1 entries
    time: [255.69 ns 256.21 ns 256.75 ns]
    change: [-0.2349% +0.0736% +0.3546%] (p = 0.65 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [291.48 ns 292.36 ns 293.48 ns]
    change: [-0.0297% +2.2649% +7.2519%] (p = 0.24 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [290.92 ns 292.34 ns 294.03 ns]
    change: [-0.8744% -0.2622% +0.2777%] (p = 0.39 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [267.81 ns 268.04 ns 268.32 ns]
    change: [-0.6724% -0.0983% +0.5446%] (p = 0.76 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [126.31 ms 126.46 ms 126.69 ms]
    change: [-0.8226% -0.5934% -0.3778%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • Run multiple transfers with varying seeds
    time: [189.97 ms 190.59 ms 191.20 ms]
    change: [-1.2513% -0.8146% -0.3553%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • Run multiple transfers with the same seed
    time: [190.89 ms 191.27 ms 191.67 ms]
    change: [-0.9411% -0.6728% -0.3893%] (p = 0.00 < 0.05)
    Change within noise threshold.

⬇️ Download logs

@larseggert
Copy link
Collaborator Author

Merging this into #1750

@larseggert larseggert closed this Mar 16, 2024
auto-merge was automatically disabled March 16, 2024 23:24

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants