Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(.github/interop): use markdown table #1743

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Mar 14, 2024

  1. Provide --markdown flag to QUIC Interop Runner to get markdown formatted table.
  2. Ignore all log output, but table.

Previous work: quic-interop/quic-interop-runner#372

1. Provide `--markdown` flag to QUIC Interop Runner to get markdown formatted table.
2. Ignore all log output, but table.
Copy link

Benchmark results

  • coalesce_acked_from_zero 1+1 entries
    time: [255.43 ns 255.96 ns 256.54 ns]
    change: [+1.6079% +2.0085% +2.3593%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 3+1 entries
    time: [290.39 ns 291.07 ns 291.82 ns]
    change: [+1.2481% +1.6468% +2.1096%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 10+1 entries
    time: [289.34 ns 289.84 ns 290.50 ns]
    change: [+0.8115% +1.3988% +1.8870%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 1000+1 entries
    time: [267.43 ns 267.58 ns 267.75 ns]
    change: [+2.7303% +3.3853% +4.0226%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • RxStreamOrderer::inbound_frame()
    time: [127.89 ms 127.94 ms 128.00 ms]
    change: [+4.7731% +4.8470% +4.9193%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • Run multiple transfers with varying seeds
    time: [188.96 ms 189.59 ms 190.21 ms]
    change: [-6.3790% -5.9374% -5.5154%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • Run multiple transfers with the same seed
    time: [190.31 ms 190.68 ms 191.04 ms]
    change: [-4.8792% -4.6348% -4.3731%] (p = 0.00 < 0.05)
    💚 Performance has improved.

⬇️ Download logs

@larseggert larseggert added this pull request to the merge queue Mar 14, 2024
Merged via the queue into mozilla:main with commit 92db586 Mar 14, 2024
14 checks passed
cat quic-interop-runner/summary >> comment
echo '```' >> comment
# Ignore all, but table, which starts with "|:--".
cat quic-interop-runner/summary | awk '/^\|:--/{flag=1} flag' >> comment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just grep '^\|:--' quic-interop-runner/summary >> comment ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 created a follow-up @martinthomson #1747.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants