Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Retry sccache with a GCS backend #1755

Closed
wants to merge 4 commits into from

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

Benchmark results

Performance differences relative to 32ef2c3.

  • coalesce_acked_from_zero 1+1 entries
    time: [192.49 ns 192.95 ns 193.45 ns]
    change: [-3.1597% -2.8473% -2.5239%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 3+1 entries
    time: [234.94 ns 235.39 ns 235.91 ns]
    change: [-4.2718% -3.8725% -3.5182%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 10+1 entries
    time: [234.84 ns 235.74 ns 236.76 ns]
    change: [-4.6099% -3.6425% -2.8347%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 1000+1 entries
    time: [214.42 ns 224.38 ns 246.24 ns]
    change: [-4.7884% -2.5446% +1.3755%] (p = 0.10 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [120.32 ms 120.48 ms 120.72 ms]
    change: [+0.0102% +0.1659% +0.3894%] (p = 0.08 > 0.05)
    No change in performance detected.

  • transfer/Run multiple transfers with varying seeds
    time: [117.53 ms 117.77 ms 118.01 ms]
    thrpt: [33.896 MiB/s 33.965 MiB/s 34.035 MiB/s]
    change:
    time: [-0.4840% -0.1650% +0.1687%] (p = 0.33 > 0.05)
    thrpt: [-0.1684% +0.1653% +0.4864%]
    No change in performance detected.

  • transfer/Run multiple transfers with the same seed
    time: [118.19 ms 118.33 ms 118.48 ms]
    thrpt: [33.761 MiB/s 33.803 MiB/s 33.844 MiB/s]
    change:
    time: [-0.2112% -0.0146% +0.1710%] (p = 0.88 > 0.05)
    thrpt: [-0.1707% +0.0146% +0.2116%]
    No change in performance detected.

⬇️ Download logs

Comment on lines +43 to +46
# - name: Authenticate to Google Cloud
# uses: google-github-actions/auth@v2
# with:
# credentials_json: '${{ inputs.token }}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@larseggert larseggert closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants