Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run clippy for all features except gecko #1768

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Mar 22, 2024

Because it didn't get to have opinions about benches and various other code before that was hidden behind features. Avoids bitrot, too.

.github/workflows/check.yml Outdated Show resolved Hide resolved
Co-authored-by: Max Inden <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Copy link

Benchmark results

Performance differences relative to bb3ab60.

  • coalesce_acked_from_zero 1+1 entries
    time: [196.73 ns 197.18 ns 197.64 ns]
    change: [-0.0553% +0.4174% +0.9343%] (p = 0.10 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [236.98 ns 237.67 ns 238.37 ns]
    change: [+0.3066% +0.6768% +1.0855%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 10+1 entries
    time: [237.00 ns 237.88 ns 238.85 ns]
    change: [-0.0568% +0.4324% +0.8835%] (p = 0.08 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [215.30 ns 215.53 ns 215.92 ns]
    change: [-0.3978% +0.2405% +0.8169%] (p = 0.47 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [117.85 ms 117.92 ms 118.00 ms]
    change: [-0.5954% -0.4998% -0.4044%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [117.55 ms 117.80 ms 118.05 ms]
    thrpt: [33.883 MiB/s 33.955 MiB/s 34.028 MiB/s]
    change:
    time: [-0.7433% -0.4288% -0.1076%] (p = 0.01 < 0.05)
    thrpt: [+0.1077% +0.4307% +0.7488%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [118.72 ms 118.88 ms 119.05 ms]
    thrpt: [33.598 MiB/s 33.646 MiB/s 33.693 MiB/s]
    change:
    time: [-0.1058% +0.0936% +0.2914%] (p = 0.38 > 0.05)
    thrpt: [-0.2905% -0.0935% +0.1059%]
    No change in performance detected.

⬇️ Download logs

@larseggert larseggert added this pull request to the merge queue Mar 25, 2024
Merged via the queue into mozilla:main with commit 50876af Mar 25, 2024
14 checks passed
@larseggert larseggert deleted the ci-clippy-all-the-things branch March 25, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants