Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable some caching #1769

Closed
wants to merge 2 commits into from
Closed

Conversation

larseggert
Copy link
Collaborator

The docker and python caches put quite a bit of stress on the GHA cache, causing it - for example - to time out the benchmark results too soon. See https://github.com/mozilla/neqo/actions/caches

(Need to check how much slower this makes the build though, hence draft PR.)

The docker and python caches put quite a bit of stress on the GHA cache,
causing it - for example - to time out the benchmark results too soon.
See https://github.com/mozilla/neqo/actions/caches
@larseggert
Copy link
Collaborator Author

Closed in favor of #1770

@larseggert larseggert closed this Mar 23, 2024
@larseggert larseggert deleted the ci-cache-less branch March 23, 2024 07:39
Copy link

Benchmark results

Performance differences relative to bb3ab60.

  • coalesce_acked_from_zero 1+1 entries
    time: [195.09 ns 195.49 ns 195.94 ns]
    change: [-0.7990% -0.3807% +0.0404%] (p = 0.07 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [235.31 ns 235.93 ns 236.62 ns]
    change: [-0.4294% -0.1159% +0.2111%] (p = 0.47 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [234.06 ns 234.62 ns 235.32 ns]
    change: [-1.0856% -0.6206% -0.1851%] (p = 0.01 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 1000+1 entries
    time: [215.19 ns 215.49 ns 215.88 ns]
    change: [-0.1484% +0.5619% +1.3377%] (p = 0.12 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [117.99 ms 118.07 ms 118.16 ms]
    change: [-0.4741% -0.3742% -0.2798%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [120.90 ms 121.20 ms 121.48 ms]
    thrpt: [32.926 MiB/s 33.004 MiB/s 33.084 MiB/s]
    change:
    time: [+2.0893% +2.4389% +2.7740%] (p = 0.00 < 0.05)
    thrpt: [-2.6991% -2.3809% -2.0465%]
    💔 Performance has regressed.

  • transfer/Run multiple transfers with the same seed
    time: [121.94 ms 122.09 ms 122.24 ms]
    thrpt: [32.722 MiB/s 32.763 MiB/s 32.803 MiB/s]
    change:
    time: [+2.5979% +2.7916% +2.9953%] (p = 0.00 < 0.05)
    thrpt: [-2.9082% -2.7158% -2.5321%]
    💔 Performance has regressed.

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant