fix: Make anti-replay window 1s for tests #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused some test failures, and @martinthomson discovered this as the reason at the IETF 120 hackathon. Broken out of mozilla#1998
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
larseggert
changed the title
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2116 +/- ##
==========================================
- Coverage 95.35% 95.31% -0.04%
==========================================
Files 112 112
Lines 36319 36319
==========================================
- Hits 34631 34618 -13
- Misses 1688 1701 +13 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to eb3e835. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.248 ns 99.583 ns 99.920 ns]
change: [-1.0050% -0.4689% +0.0389%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.98 ns 117.31 ns 117.66 ns]
change: [-1.5999% -0.9806% -0.4787%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.05 ns 117.67 ns 118.36 ns]
change: [-0.5843% +0.2388% +1.2175%] (p = 0.66 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [97.114 ns 97.282 ns 97.482 ns]
change: [-2.0264% -1.1891% -0.2712%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.08 ms 111.10 ms 111.13 ms]
change: [+0.2503% +0.3099% +0.3676%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.855 ms 27.950 ms 29.046 ms]
change: [-3.0551% +2.3500% +7.8736%] (p = 0.41 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.725 ms 36.596 ms 38.517 ms]
change: [-2.9808% +3.7361% +11.068%] (p = 0.29 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [25.848 ms 26.757 ms 27.692 ms]
change: [-0.6160% +3.7481% +8.3288%] (p = 0.11 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.686 ms 41.622 ms 43.630 ms]
change: [-4.3493% +2.6326% +10.058%] (p = 0.46 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [114.68 ms 115.05 ms 115.39 ms]
thrpt: [866.64 MiB/s 869.22 MiB/s 872.00 MiB/s]
change:
time: [+0.1147% +1.2761% +2.1353%] (p = 0.01 < 0.05)
thrpt: [-2.0907% -1.2601% -0.1146%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [316.37 ms 320.44 ms 324.47 ms]
thrpt: [30.820 Kelem/s 31.207 Kelem/s 31.609 Kelem/s]
change:
time: [-0.7967% +0.8859% +2.6383%] (p = 0.32 > 0.05)
thrpt: [-2.5705% -0.8781% +0.8031%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.753 ms 33.919 ms 34.095 ms]
thrpt: [29.329 elem/s 29.482 elem/s 29.627 elem/s]
change:
time: [-0.9178% -0.1556% +0.6012%] (p = 0.69 > 0.05)
thrpt: [-0.5976% +0.1558% +0.9263%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused some test failures, and @martinthomson discovered this as the reason at the IETF 120 hackathon.
Broken out of #1998