Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use Rust stable to benchmark #2131

Merged
merged 2 commits into from
Sep 20, 2024
Merged

ci: Use Rust stable to benchmark #2131

merged 2 commits into from
Sep 20, 2024

Conversation

larseggert
Copy link
Collaborator

Nightly might have performance regressions.

@larseggert
ci: Use Rust stable to benchmark
ed30633 
Nightly might have performance regressions.
mxinden
mxinden approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me in general.

I assume you don't have a particular recent slow-down in nightly in mind?

@larseggert
Copy link
Collaborator Author

I do; #2130 (comment)

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (b6aa402) to head (8573f71).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2131   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         112      112           
  Lines       36335    36335           
=======================================
  Hits        34648    34648           
  Misses       1687     1687

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

@larseggert larseggert added this pull request to the merge queue Sep 20, 2024
Merged via the queue into mozilla:main with commit d513712 Sep 20, 2024
60 of 62 checks passed
@larseggert larseggert deleted the ci-bench-stable branch September 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larseggert @mxinden