Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v0.9.1 release #2148

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

Copy link

github-actions bot commented Oct 3, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@larseggert
Copy link
Collaborator

Don't you want to wait for #2093?

Copy link

github-actions bot commented Oct 3, 2024

Benchmark results

Performance differences relative to 12ff014.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [98.809 ns 99.090 ns 99.382 ns]
       change: [-0.6341% -0.1684% +0.3496%] (p = 0.49 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [116.72 ns 117.07 ns 117.43 ns]
       change: [-0.6758% -0.3252% +0.0341%] (p = 0.09 > 0.05)

Found 22 outliers among 100 measurements (22.00%)
2 (2.00%) low severe
1 (1.00%) low mild
6 (6.00%) high mild
13 (13.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [116.13 ns 116.24 ns 116.46 ns]
       change: [-4.4157% -2.0512% -0.5993%] (p = 0.02 < 0.05)

Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) low severe
5 (5.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.254 ns 98.597 ns 101.50 ns]
       change: [-1.7188% +8.3376% +35.023%] (p = 0.60 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.41 ms 111.46 ms 111.52 ms]
       change: [-0.2093% -0.0220% +0.1048%] (p = 0.84 > 0.05)

Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) low mild
2 (2.00%) high mild

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [27.706 ms 28.756 ms 29.775 ms]
       change: [-4.4816% +0.8477% +6.1549%] (p = 0.75 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) low mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [37.108 ms 38.984 ms 40.869 ms]
       change: [-4.3302% +1.8007% +8.5808%] (p = 0.60 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) low mild
2 (2.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [26.168 ms 27.086 ms 27.994 ms]
       change: [-6.7861% -2.4690% +1.9827%] (p = 0.29 > 0.05)
transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [40.147 ms 42.046 ms 43.977 ms]
       change: [-13.266% -7.4613% -1.3520%] (p = 0.02 < 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold.
       time:   [114.19 ms 114.48 ms 114.77 ms]
       thrpt:  [871.33 MiB/s 873.49 MiB/s 875.73 MiB/s]
change:
       time:   [+0.6985% +1.2202% +1.7856%] (p = 0.00 < 0.05)
       thrpt:  [-1.7543% -1.2055% -0.6936%]

Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low severe
1 (1.00%) low mild
1 (1.00%) high mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [309.85 ms 313.52 ms 317.13 ms]
       thrpt:  [31.532 Kelem/s 31.896 Kelem/s 32.273 Kelem/s]
change:
       time:   [-2.3749% -0.8332% +0.7902%] (p = 0.30 > 0.05)
       thrpt:  [-0.7840% +0.8402% +2.4327%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.621 ms 33.780 ms 33.953 ms]
       thrpt:  [29.452  elem/s 29.604  elem/s 29.743  elem/s]
change:
       time:   [-1.3307% -0.5725% +0.2008%] (p = 0.16 > 0.05)
       thrpt:  [-0.2004% +0.5758% +1.3487%]

Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) low mild
2 (2.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 186.3 ± 110.2 97.5 528.7 1.00
neqo msquic reno on 242.4 ± 56.7 214.6 418.3 1.00
neqo msquic reno 303.9 ± 140.6 213.4 644.7 1.00
neqo msquic cubic on 244.1 ± 66.3 209.8 451.9 1.00
neqo msquic cubic 249.0 ± 67.9 212.2 456.7 1.00
msquic neqo reno on 170.8 ± 95.0 85.0 354.8 1.00
msquic neqo reno 137.8 ± 74.2 86.8 318.8 1.00
msquic neqo cubic on 131.4 ± 75.8 83.5 324.2 1.00
msquic neqo cubic 175.2 ± 98.5 94.1 359.4 1.00
neqo neqo reno on 191.0 ± 59.2 137.1 346.4 1.00
neqo neqo reno 183.6 ± 72.7 124.8 395.5 1.00
neqo neqo cubic on 241.2 ± 121.4 135.5 455.3 1.00
neqo neqo cubic 190.4 ± 97.4 128.5 539.6 1.00

⬇️ Download logs

@mxinden
Copy link
Collaborator Author

mxinden commented Oct 3, 2024

Don't you want to wait for #2093?

#2093 is a large change, thus hard to estimate when it will merge. More generally, I prefer not blocking bugfixes on feature work.

Copy link

github-actions bot commented Oct 3, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (12ff014) to head (d19dda2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   95.35%   95.35%   -0.01%     
==========================================
  Files         112      112              
  Lines       36357    36357              
==========================================
- Hits        34669    34668       -1     
- Misses       1688     1689       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert added this pull request to the merge queue Oct 3, 2024
Merged via the queue into mozilla:main with commit 1708886 Oct 3, 2024
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants