test(SentPackets): ignore unknown packet #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test written while debugging https://bugzilla.mozilla.org/show_bug.cgi?id=1919678.
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
==========================================
- Coverage 95.35% 95.35% -0.01%
==========================================
Files 112 112
Lines 36357 36362 +5
==========================================
+ Hits 34669 34673 +4
- Misses 1688 1689 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 12fc1aa. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.646 ns 99.002 ns 99.373 ns]
change: [-0.1398% +0.2435% +0.6365%] (p = 0.22 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.52 ns 116.82 ns 117.17 ns]
change: [-0.2578% +0.3617% +0.9384%] (p = 0.26 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.04 ns 116.35 ns 116.77 ns]
change: [-0.6577% -0.0032% +0.5882%] (p = 0.99 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.655 ns 103.46 ns 115.92 ns]
change: [-1.1936% +1.6594% +6.2452%] (p = 0.55 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.02 ms 111.16 ms 111.38 ms]
change: [-0.6960% -0.4457% -0.2058%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [27.799 ms 28.931 ms 30.080 ms]
change: [+1.6590% +6.9159% +12.237%] (p = 0.02 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [36.153 ms 37.939 ms 39.748 ms]
change: [-2.8666% +3.8466% +11.290%] (p = 0.29 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [26.279 ms 27.039 ms 27.804 ms]
change: [+0.8669% +5.0989% +9.4796%] (p = 0.01 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [40.161 ms 41.883 ms 43.611 ms]
change: [-5.6223% +0.6966% +7.4694%] (p = 0.84 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [112.17 ms 112.60 ms 113.02 ms]
thrpt: [884.78 MiB/s 888.06 MiB/s 891.47 MiB/s]
change:
time: [-1.6006% -1.0370% -0.4835%] (p = 0.00 < 0.05)
thrpt: [+0.4858% +1.0478% +1.6267%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [310.35 ms 314.50 ms 318.53 ms]
thrpt: [31.394 Kelem/s 31.796 Kelem/s 32.222 Kelem/s]
change:
time: [-1.6577% +0.1114% +1.8494%] (p = 0.90 > 0.05)
thrpt: [-1.8158% -0.1113% +1.6856%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.972 ms 34.185 ms 34.417 ms]
thrpt: [29.056 elem/s 29.253 elem/s 29.436 elem/s]
change:
time: [-0.7247% +0.0481% +0.9015%] (p = 0.90 > 0.05)
thrpt: [-0.8935% -0.0481% +0.7300%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test written while debugging https://bugzilla.mozilla.org/show_bug.cgi?id=1919678.