ci: Don't run QNS when a PR is merged #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't run it on a schedule anymore.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2161 +/- ##
==========================================
- Coverage 95.39% 95.38% -0.01%
==========================================
Files 112 112
Lines 36373 36373
==========================================
- Hits 34697 34696 -1
- Misses 1676 1677 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 5677bd1. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.591 ns 98.894 ns 99.212 ns]
change: [-0.3848% +0.0637% +0.5182%] (p = 0.78 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.42 ns 116.65 ns 116.91 ns]
change: [-0.2102% +0.1014% +0.4298%] (p = 0.54 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.02 ns 116.37 ns 116.81 ns]
change: [-0.5855% -0.2218% +0.0999%] (p = 0.22 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.029 ns 97.152 ns 97.290 ns]
change: [-1.7601% -0.7178% +0.2105%] (p = 0.19 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.93 ms 111.99 ms 112.06 ms]
change: [+0.6444% +0.7286% +0.8087%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.670 ms 27.713 ms 28.767 ms]
change: [-1.7805% +3.1823% +8.2352%] (p = 0.22 > 0.05)
transfer/pacing-true/varying-seeds: 💔 Performance has regressed. time: [37.317 ms 39.120 ms 40.945 ms]
change: [+4.0937% +11.492% +19.058%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [27.110 ms 27.881 ms 28.672 ms]
change: [+2.1107% +6.1447% +10.958%] (p = 0.01 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [42.846 ms 44.882 ms 46.974 ms]
change: [+0.5146% +7.4912% +14.984%] (p = 0.03 < 0.05)
1-conn/1-100mb-resp (aka. Download)/client: 💔 Performance has regressed. time: [115.35 ms 115.79 ms 116.21 ms]
thrpt: [860.51 MiB/s 863.62 MiB/s 866.91 MiB/s]
change:
time: [+1.2680% +1.7475% +2.2566%] (p = 0.00 < 0.05)
thrpt: [-2.2068% -1.7175% -1.2521%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [317.83 ms 321.27 ms 324.69 ms]
thrpt: [30.799 Kelem/s 31.126 Kelem/s 31.464 Kelem/s]
change:
time: [-0.3420% +1.2784% +2.7536%] (p = 0.12 > 0.05)
thrpt: [-2.6798% -1.2623% +0.3432%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.986 ms 34.205 ms 34.451 ms]
thrpt: [29.027 elem/s 29.236 elem/s 29.424 elem/s]
change:
time: [-0.6219% +0.1458% +0.9559%] (p = 0.72 > 0.05)
thrpt: [-0.9469% -0.1456% +0.6258%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
reviewed
Oct 8, 2024
mxinden
approved these changes
Oct 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't run it on a schedule anymore.