feat: Try FxHasher to see if it makes a difference #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2342 +/- ##
==========================================
- Coverage 95.48% 95.29% -0.19%
==========================================
Files 114 114
Lines 36899 36844 -55
Branches 36899 36844 -55
==========================================
- Hits 35233 35111 -122
- Misses 1660 1727 +67
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 648863b. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 085fa62. decode 4096 bytes, mask ff: 💔 Performance has regressed. time: [11.861 µs 11.902 µs 11.949 µs]
change: [+5.8804% +7.8916% +11.491%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [2.9236 ms 2.9334 ms 2.9448 ms]
change: [-4.1088% -3.4258% -2.7991%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: 💔 Performance has regressed. time: [19.787 µs 19.853 µs 19.940 µs]
change: [+1.0995% +1.6042% +2.2302%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 7f: 💚 Performance has improved. time: [5.0426 ms 5.0525 ms 5.0637 ms]
change: [-3.6086% -2.7305% -2.1137%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: 💔 Performance has regressed. time: [6.9204 µs 6.9898 µs 7.0877 µs]
change: [+24.184% +25.026% +26.078%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 3f: 💚 Performance has improved. time: [1.4137 ms 1.4193 ms 1.4262 ms]
change: [-19.528% -19.279% -18.880%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.716 ns 98.957 ns 99.214 ns]
change: [-0.5858% -0.1888% +0.2113%] (p = 0.37 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.95 ns 117.32 ns 117.72 ns]
change: [-0.5470% -0.0151% +0.4738%] (p = 0.96 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.83 ns 117.41 ns 118.07 ns]
change: [-0.0844% +0.6105% +1.4908%] (p = 0.14 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.938 ns 98.074 ns 98.233 ns]
change: [-0.2193% +0.6477% +1.5933%] (p = 0.16 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.49 ms 111.54 ms 111.60 ms]
change: [+0.0598% +0.2208% +0.3414%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.5118 µs 5.6896 µs 5.8800 µs]
change: [-2.5275% +0.3139% +3.4595%] (p = 0.83 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [42.654 ms 42.739 ms 42.830 ms]
change: [+1.8448% +2.1175% +2.4029%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.995 ms 43.077 ms 43.161 ms]
change: [+2.1200% +2.4231% +2.7105%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [42.502 ms 42.567 ms 42.641 ms]
change: [+1.0850% +1.3050% +1.5377%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💔 Performance has regressed. time: [42.808 ms 42.884 ms 42.962 ms]
change: [+3.1061% +3.3696% +3.6433%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [879.56 ms 889.26 ms 899.13 ms]
thrpt: [111.22 MiB/s 112.45 MiB/s 113.69 MiB/s]
change:
time: [-5.4489% -3.9386% -2.4151%] (p = 0.00 < 0.05)
thrpt: [+2.4749% +4.1001% +5.7629%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [310.16 ms 312.42 ms 314.71 ms]
thrpt: [31.775 Kelem/s 32.008 Kelem/s 32.241 Kelem/s]
change:
time: [-2.9303% -1.9932% -0.9754%] (p = 0.00 < 0.05)
thrpt: [+0.9850% +2.0338% +3.0187%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.130 ms 34.307 ms 34.501 ms]
thrpt: [28.984 elem/s 29.149 elem/s 29.300 elem/s]
change:
time: [-0.7541% -0.0180% +0.7494%] (p = 0.96 > 0.05)
thrpt: [-0.7438% +0.0180% +0.7598%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.6887 s 1.7064 s 1.7239 s]
thrpt: [58.009 MiB/s 58.603 MiB/s 59.217 MiB/s]
change:
time: [-1.5284% -0.1480% +1.2696%] (p = 0.83 > 0.05)
thrpt: [-1.2537% +0.1482% +1.5521%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP