test(transport/vn): allow dropped_rx of 1 #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compatible_upgrade_large_initial` tests whether Neqo can handle an ACK using QUIC version Y on a connection that ends up using QUIC version X. mozilla#2228 changed the test, asserting that the server will drop 2 instead of 1 packet. This spuriosly fails on CI: https://github.com/mozilla/neqo/actions/runs/12796212878/job/35675377711?pr=2295 This commit allows both 1 and 2 packets dropped by the server.
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 7f8136e. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
==========================================
- Coverage 95.29% 95.29% -0.01%
==========================================
Files 114 114
Lines 36856 36843 -13
Branches 36856 36843 -13
==========================================
- Hits 35123 35110 -13
Misses 1727 1727
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Correct.
Sounds like a plan. That said, I would like merge #2295 rather earlier than later, i.e. not block it on another pull request. We currently run Firefox with Cubic but our unit tests with New Reno. I fear we might introduce a regression. @larseggert objections to the following plan?
|
larseggert
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatible_upgrade_large_initialtests whether Neqo can handle an ACK using QUIC version Y on a connection that ends up using QUIC version X.#2228 changed the test, asserting that the server will drop 2 instead of 1 packet. This spuriosly fails on CI:
https://github.com/mozilla/neqo/actions/runs/12796212878/job/35675377711?pr=2295
This commit allows both 1 and 2 packets dropped by the server.
@larseggert based on your changes in #2228, is this a valid assumption to make?