Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't translate char codes when platform,encoding isn't (3,0) #17810

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Don't translate char codes when platform,encoding isn't (3,0) #17810

merged 1 commit into from
Apr 3, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

@Snuffleupagus, I'm not very sure of what I'm doing... so don't worry to take the ownership if you've a better idea.

@Snuffleupagus Snuffleupagus changed the title Don't translate char codes when platorm,encoding isn't (3,0) Don't translate char codes when platform,encoding isn't (3,0) Mar 20, 2024
@Snuffleupagus
Copy link
Collaborator

There's a typo in the commit message: platorm -> platform

Also, for this sort of change, running all tests before asking for feedback/review seems like a good idea :-)

@timvandermeij
Copy link
Contributor

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/22c2f1eac44880d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fb72956e18a6cbd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/22c2f1eac44880d/output.txt

Total script time: 25.74 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/22c2f1eac44880d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fb72956e18a6cbd/output.txt

Total script time: 40.56 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 6

Image differences available at: http://54.193.163.58:8877/fb72956e18a6cbd/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

Astonishingly, it worked... :)
I just fixed the typo in the commit message.

@Snuffleupagus Snuffleupagus linked an issue Mar 21, 2024 that may be closed by this pull request
PDF Document does not display text correctly when rendered in pdf.js #17808
Closed
Snuffleupagus
Snuffleupagus approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While test coverage should be pretty good for this part of the font code, we probably need to be prepared for regressions from this change nonetheless.

r=me, thank you!

@marco-c
Copy link
Contributor

marco-c commented Mar 21, 2024

If the change is risky, I'd suggest waiting a bit before landing to make uplifts to 125 easier.

@Snuffleupagus
Copy link
Collaborator

If the change is risky, I'd suggest waiting a bit before landing to make uplifts to 125 easier.

Given that https://bugzilla.mozilla.org/show_bug.cgi?id=1889118 was recently landed, should we try merging this PR now?

@marco-c
Copy link
Contributor

marco-c commented Apr 3, 2024

Yes, I think we're safe to land it now!

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6eee18aeb805773/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/681b3d20b6538f9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6eee18aeb805773/output.txt

Total script time: 26.32 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/6eee18aeb805773/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/681b3d20b6538f9/output.txt

Total script time: 43.00 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/681b3d20b6538f9/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit d8331e3 into mozilla:master Apr 3, 2024
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/351474da27bb882/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/22cf15b9bcd5951/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/351474da27bb882/output.txt

Total script time: 18.88 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/22cf15b9bcd5951/output.txt

Total script time: 27.20 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
font-conversion font-truetype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF Document does not display text correctly when rendered in pdf.js
5 participants
@calixteman @Snuffleupagus @timvandermeij @moz-tools-bot @marco-c