Fix #2: Skip downloads if pip is correct version #4
Conversation
pmclanahan
force-pushed
the
skip-if-pip-up-to-date
branch
from
8f206c9 to
018d177
Compare
|
Rebased on current master. Any thoughts on this @erikrose ? |
|
In the last week, I have realized just how deep the packaging rabbit hole goes. Since shipping peep with Let's Encrypt, I've been a party to bug after bug in pip and friends (which I see, since peep emits bug-reporting instructions), to the point where I no longer trust shipping anything but a fully pinned trio of pip, setuptools, and wheel and installing into an empty virtualenv with the wheel cache off. At the very least, I then can reproduce reported bugs. (In fact, I'm conflicted about the "if" around argparse.) If we could check the versions of all of the packages pipstrap cares about ( |
|
My thought here was simply that if the environment already has a pip at the current version, then we can assume that pipstrap had been previously run successfully. I'm just using it as a proxy. If you think this will introduce bugs and maintenance overhead for you then I'm happy to work around this in my own deployment scripts. My goal was simply to make this a bit faster and require no network in situations when this gets run every time (e.g. CI) but sometimes the venv was cached and downloading these packages again is superfluous. |
* Factor up pip version. * Pass quietly if all goes well. This should also relieve our dependency on a Unix-like shell. * Drop shell use for vague notion of security. * Avoid variable reassignment.
* Factor up pip version. * Pass quietly if all goes well. This should also relieve our dependency on a Unix-like shell. * Drop shell use for vague notion of security. * Avoid variable reassignment.
|
Sorry for the long wait, pmac. I've subsumed this into #9. |
Decided to go ahead and file the PR just in case you liked the idea.
Thanks again for pipstrap Erik! It's been a massive time saver for us.