Optimize map accesses in several places #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
force-pushed
the
optimize-map-access
branch
from
5616739
to
972f5e2
Compare
rPraml
commented
Sep 23, 2024
| // Update the existing value and keep it in the same place in the list | ||
| map.get(nv).value = value; | ||
| } | ||
| map.compute( |
There was a problem hiding this comment.
we will save one hash computation, but have the price of an additional invocation of a lambda expression:
I did this short test:
@Test
public void speed() {
for (long i = 0L; i < 10_000_000L; i++) {
ht.put("one", 1);
ht.put("two", 2);
ht.put("three", 3);
ht.put("four", 4);
ht.put("five", 5);
ht.put("six", 6);
ht.put("seven", 7);
ht.put("eight", 8);
ht.put("nine", 9);
ht.put("ten", 10);
}
}it runs with the old code in apporx 8,5sec and with the new code approx 5,5 sec
| @@ -595,23 +599,21 @@ private void reflect( | |||
| NativeJavaMethod setters = null; | |||
| String setterName = "set".concat(nameComponent); | |||
|
|
|||
| if (ht.containsKey(setterName)) { | |||
There was a problem hiding this comment.
I think we can safely remove containsKey here, as we call get in the next line, which is checked for null by the instanceOf test.
| @@ -687,13 +689,11 @@ private Field[] getAccessibleFields(boolean includeProtected, boolean includePri | |||
| private static MemberBox findGetter( | |||
| boolean isStatic, Map<String, Object> ht, String prefix, String propertyName) { | |||
| String getterName = prefix.concat(propertyName); | |||
| if (ht.containsKey(getterName)) { | |||
| // Check that the getter is a method. | |||
| Object member = ht.get(getterName); | |||
There was a problem hiding this comment.
same here. Do not hit map twice
|
Yes, this is a good change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I will try to optimize map access on several places and pick up @gbrail's comment: #1575 (comment)