Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the slowest Mozilla Suite tests at lower optimization levels #1653

Closed
wants to merge 1 commit into from

Conversation

gbrail
Copy link
Collaborator

@gbrail gbrail commented Sep 26, 2024

Turn off the slowest tests at opt levels -1 and 0. We still run
these tests at opt level 9, which should be enough to test for what they're
actually testing for.

For example, there is a Date test that loops through every hour for a year
and ensures that a Date can be created and not die a horrible death.
I'm not sure that we really need that and we certainly don't need to
test it three times!

Turn off the slowest tests at opt levels -1 and 0. We still run
these tests at opt level 9, which should be enough to test for what they're
actually testing for.
@p-bakker
Copy link
Collaborator

p-bakker commented Sep 26, 2024

Don't we need to at least test at -1 (interpreted) and then one of the compiled levels (0 through 9)?

And speaking of those different optLevels for compiled mode: is there actually any difference between them? See #1123

@gbrail
Copy link
Collaborator Author

gbrail commented Sep 26, 2024 via email

@p-bakker
Copy link
Collaborator

but I think that the only difference is whether the
optimizer tries to replace strings of numeric functions with floating-point
operations directly in the bytecode

If you figure it out, please let us know (so I can also point to that in the documentation). I wasn't able to find anything previously, whick would mean we could just completely disable running the testsuite for one of the two compiled opt levels

TBH, I'm not convinced that we need all of these MozillaSuiteTests at all

I guess you're talking about specific tests from the testsuite. I've been wondering myself as well, because to my knowledge a fair chunk of this testsuite was shared with SpiderMonkey and those test got rolled into Test262 if I'm not mistaken, so there might be a lot of overlap

@gbrail
Copy link
Collaborator Author

gbrail commented Oct 7, 2024

I'm going to close this for now -- I think that we can figure out whether we really need three optimization levels first. Also, I think that we can also get rid of a few of these tests just because they do crazy things like make sure that we can convert every date in a year in a giant slow loop...

@gbrail gbrail closed this Oct 7, 2024
@gbrail gbrail deleted the less-mozilla branch October 7, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants