The $262 object does not use LiveConnect any more #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
commented
Sep 30, 2024
|
|
||
| // same as cx.evaluateString(scope, "var $262 = new __262__()", "<init>", 1, null); | ||
| BaseFunction ctor = (BaseFunction) scope.get("__262__", scope); | ||
| $262.install(scope, ctor.construct(cx, scope, new Object[0])); |
There was a problem hiding this comment.
The initialization looks a bit strange to me, maybe some experts can give me hints how do I write cleaner code here?
I also took __262__ as class name, which is somehow required
|
The initialization makes sense to me if it's using the reflection based attributes there. You could also just create a ScriptableObject and attach LambdaFunctions to it if you'd like to do it a different way -- the latter is a bit faster once it's set up. There's a method in ScriptableObject that does it quickly but it's protected -- but it could be public. |
rbri
reviewed
Oct 1, 2024
| proto.setPrototype(getObjectPrototype(scope)); | ||
| proto.setParentScope(scope); | ||
|
|
||
| proto.defineProperty("toSource", "Math", DONTENUM | READONLY | PERMANENT); |
|
Great - the lambda thing is much better - at least from my point of view - thanks a lot |
rPraml
force-pushed
the
test-262-no-dependency-on-liveconnect
branch
from
0492c78
to
9caa579
Compare
rbri
approved these changes
Oct 1, 2024
|
Thanks -- looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed, that the $262 object, which defines the host functions was wrapped into a NativeJavaObject.
In other words, the
@JsMethodannotations were useless, instead, the methods were exposed by LiveConnect.In this PR, I've changed the $262 to a subclass of ScriptableObject, so that the annotations take place and we do not longer depend on LC when running the 262 tests.