Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc for cmake 3.25 on windows #1873

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

ahoarau
Copy link
Contributor

@ahoarau ahoarau commented Sep 1, 2023

CMake 3.25 introduces the new CMAKE_MSVC_DEBUG_INFORMATION_FORMAT that allow to set the -Z7 option, mandatory on windows . ref: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_DEBUG_INFORMATION_FORMAT.html

CMake 3.25 introduces the new CMAKE_MSVC_DEBUG_INFORMATION_FORMAT that allow to set the -Z7 option, mandatory on windows . ref: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_DEBUG_INFORMATION_FORMAT.html
README.md Outdated Show resolved Hide resolved
Co-authored-by: Sylvestre Ledru <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.44% 🎉

Comparison is base (7074753) 29.46% compared to head (02e2f97) 29.90%.
Report is 3 commits behind head on main.

❗ Current head 02e2f97 differs from pull request most recent head c3a7355. Consider uploading reports for the commit c3a7355 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
+ Coverage   29.46%   29.90%   +0.44%     
==========================================
  Files          49       49              
  Lines       17844    17516     -328     
  Branches     8631     8400     -231     
==========================================
- Hits         5257     5239      -18     
+ Misses       7347     7209     -138     
+ Partials     5240     5068     -172     

see 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 6a2e27f into mozilla:main Sep 7, 2023
@ahoarau ahoarau deleted the patch-1 branch September 7, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants