-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support msvc as the host compiler for nvcc #1884
Support msvc as the host compiler for nvcc #1884
Conversation
I believe that the link issues reported in #1077 will be fixed with this PR. Since the pre-processor output is empty, each object file is empty and when you go to link you will get missing symbol errors. |
is it possible to add the test? |
Will look at the existing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
- Coverage 29.78% 29.77% -0.02%
==========================================
Files 49 49
Lines 17538 17662 +124
Branches 8440 8492 +52
==========================================
+ Hits 5224 5258 +34
- Misses 7213 7322 +109
+ Partials 5101 5082 -19
☔ View full report in Codecov by Sentry. |
@sylvestre does that test look reasonable? |
Sorry I missed your response |
bbcf02a
to
c0ad024
Compare
Closed as #1889 combines these changes with support for nvc++ which required a better design for how we track the host compiler mode for |
oh, sorry, i was afraid you were pissed :p sorry |
To support MSVC as the nvcc host compiler we need to pass
-EP
for the pre-processing step. If we pass-P
the pre-processor will place the output in<input_file>.i
and not the requested output file given by-o
.