Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support msvc as the host compiler for nvcc #1884

Conversation

robertmaynard
Copy link
Collaborator

To support MSVC as the nvcc host compiler we need to pass -EP for the pre-processing step. If we pass -P the pre-processor will place the output in <input_file>.i and not the requested output file given by -o.

@robertmaynard
Copy link
Collaborator Author

I believe that the link issues reported in #1077 will be fixed with this PR. Since the pre-processor output is empty, each object file is empty and when you go to link you will get missing symbol errors.

@sylvestre
Copy link
Collaborator

is it possible to add the test?
thanks

@robertmaynard
Copy link
Collaborator Author

is it possible to add the test? thanks

Will look at the existing run_sccache_command_tests function and see if I can figure out a pre-processor test for nvcc

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage: 10.00% and project coverage change: -0.02% ⚠️

Comparison is base (8f59a57) 29.78% compared to head (bbcf02a) 29.77%.

❗ Current head bbcf02a differs from pull request most recent head c0ad024. Consider uploading reports for the commit c0ad024 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
- Coverage   29.78%   29.77%   -0.02%     
==========================================
  Files          49       49              
  Lines       17538    17662     +124     
  Branches     8440     8492      +52     
==========================================
+ Hits         5224     5258      +34     
- Misses       7213     7322     +109     
+ Partials     5101     5082      -19     
Files Changed Coverage Δ
src/compiler/compiler.rs 36.13% <0.00%> (+0.11%) ⬆️
tests/system.rs 26.16% <10.00%> (-4.84%) ⬇️
src/compiler/nvcc.rs 41.88% <14.28%> (-0.67%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertmaynard
Copy link
Collaborator Author

@sylvestre does that test look reasonable?

@sylvestre
Copy link
Collaborator

Sorry I missed your response

@sylvestre sylvestre reopened this Sep 25, 2023
@robertmaynard
Copy link
Collaborator Author

Closed as #1889 combines these changes with support for nvc++ which required a better design for how we track the host compiler mode for nvcc.

@sylvestre
Copy link
Collaborator

oh, sorry, i was afraid you were pissed :p sorry

@sylvestre sylvestre closed this Sep 25, 2023
@robertmaynard robertmaynard deleted the fea/support_msvc_as_nvcc_host_compiler branch September 28, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants