sccache now tracks compiler hits/misses on a per language basis. #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To properly do this I hoisted the |
robertmaynard
force-pushed
the
bug/track_cache_hits_misses_per_language
branch
from
03b16ea
to
8c39367
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1895 +/- ##
==========================================
- Coverage 29.83% 29.74% -0.09%
==========================================
Files 50 50
Lines 17898 17967 +69
Branches 8624 8669 +45
==========================================
+ Hits 5339 5344 +5
- Misses 7407 7467 +60
- Partials 5152 5156 +4
☔ View full report in Codecov by Sentry. |
Previously sccache was actually tracking hits and misses on a compiler id basis, and guessing on the language. This is an issue for compilers like `clang` which support C, C++, and CUDA. In that case we want to clearly state what language we are getting hit or misses on to help user diagnose issues.
robertmaynard
force-pushed
the
bug/track_cache_hits_misses_per_language
branch
from
8c39367
to
c31b376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously sccache was actually tracking hits and misses on a compiler id basis, and guessing on the language.
This is an issue for compilers like
clangwhich support C, C++, and CUDA. In that case we want to clearly state what language we are getting hit or misses on to help user diagnose issues.