tests/system.rs Now correctly identifies apple clang #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous regex didn't have proper capture group names, and the regex didn't properly handle for spaces between `Apple` and `clang version`. Updated to also support compiler output like `Apple LLVM clang version` which I believe it used to do.
robertmaynard
force-pushed
the
bug/system.rs_test_correctly_id_apple_clang
branch
from
a52a02e
to
480a442
Compare
sylvestre
reviewed
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous regex didn't have proper capture group names, and the regex didn't properly handle for spaces between
Appleandclang version. Updated to also support compiler output likeApple LLVM clang versionwhich I believe it used to do.