Change with type to overload #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochameau
reviewed
Oct 13, 2022
Comment on lines
+239
to
241
| with<T>(rawSourceMap: RawSourceMap, sourceMapUrl: SourceMapUrl | null | undefined, callback: (consumer: BasicSourceMapConsumer) => Promise<T> | T): Promise<T>; | ||
| with<T>(rawSourceMap: RawIndexMap, sourceMapUrl: SourceMapUrl | null | undefined, callback: (consumer: IndexedSourceMapConsumer) => Promise<T> | T): Promise<T>; | ||
| with<T>(rawSourceMap: RawSourceMap | RawIndexMap | string, sourceMapUrl: SourceMapUrl | null | undefined, callback: (consumer: BasicSourceMapConsumer | IndexedSourceMapConsumer) => Promise<T> | T): Promise<T>; |
There was a problem hiding this comment.
This is confusing. I might see an improvement if you were removing the 3rd line 241.
So that we either type rawSourceMap as RawSourceMap or as RawIndex, but as-is the last line still allow mixed types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should this be like this?