Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop email format support #1541

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Drop email format support #1541

merged 1 commit into from
Nov 12, 2024

Conversation

robhudson
Copy link
Contributor

When unsent, this defaults to "H" in CTMS.

@robhudson robhudson requested a review from pmac November 8, 2024 23:51
pmac
pmac approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@pmac pmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I believe it should be fine, but we should be sure that sending a call to subscribe that includes format does not cause an error, for compatibility with existing forms.

Base automatically changed from has-fxa-always to main November 12, 2024 22:05
@robhudson
Copy link
Contributor Author

we should be sure that sending a call to subscribe that includes format does not cause an error, for compatibility with existing forms.

Yeah. The existing API should but I'll make sure there's a test for it.

@robhudson
Drop format support
8c9669a 
When unsent, this defaults to "H" in CTMS.
@robhudson robhudson merged commit 454f126 into main Nov 12, 2024
1 check passed
@robhudson robhudson deleted the remove-format branch November 12, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmac pmac pmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robhudson @pmac