-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement CIP-0025 #27
Draft
keyan-m
wants to merge
11
commits into
mpizenberg:main
Choose a base branch
from
keyan-m:feature/cip25
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Dec 27, 2023
-
Implement
File
and some datatypes for MIME typesCurrently, there is a separation between the image media type and other ones. The reason for that was due to the requirement of an image MIME type for the outer CIP-0025, while the one inside individual `File`s is allowed to be any of the MIME types (a smarter datatype management can probably address this). Also, the implemented `Image` datatype might be too excessive. An alternate solution could be utilizing the `elm/mimetype` package.
Configuration menu - View commit details
-
Copy full SHA for d18f475 - Browse repository at this point
Copy the full SHA d18f475View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5389bf4 - Browse repository at this point
Copy the full SHA 5389bf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b99040 - Browse repository at this point
Copy the full SHA 7b99040View commit details -
Configuration menu - View commit details
-
Copy full SHA for 618cf87 - Browse repository at this point
Copy the full SHA 618cf87View commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c45d8e - Browse repository at this point
Copy the full SHA 7c45d8eView commit details -
Reduce Supported Image MIME Types (For Now)
Potentially adding an "other" variant in future.
Configuration menu - View commit details
-
Copy full SHA for 466d81c - Browse repository at this point
Copy the full SHA 466d81cView commit details -
Allow for Arbitrary Fields in
File
s andCip25
I've modeled the arbitrary fields using `otherProps` accessors in both `File` and `Cip25`, with types of `Dict String Metadatum`. This could be somewhat restrictive as it only allows for `String` keys.
Configuration menu - View commit details
-
Copy full SHA for c8f9313 - Browse repository at this point
Copy the full SHA c8f9313View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9778ea0 - Browse repository at this point
Copy the full SHA 9778ea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f34a6e - Browse repository at this point
Copy the full SHA 7f34a6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 681613c - Browse repository at this point
Copy the full SHA 681613cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1c80d2 - Browse repository at this point
Copy the full SHA f1c80d2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.