fix ArrayIndexOutOfBoundsException

fix #923
mplushnikov · Sep 6, 2020 · f8b47a9 · f8b47a9
1 parent e2433c6
commit f8b47a9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/parts/pluginChanges.html b/parts/pluginChanges.html
@@ -1,7 +1,7 @@
 <ul>
   <li>0.31
     <ol>
-      <li>TODO</li>
+      <li>Fixed #923: ArrayIndexOutOfBoundsException in ReplaceExplicitTypeWithVariableIntention</li>
     </ol>
   </li>
   <li>0.30

diff --git a/...ij/plugin/intention/valvar/to/AbstractReplaceExplicitTypeWithVariableIntentionAction.java b/...ij/plugin/intention/valvar/to/AbstractReplaceExplicitTypeWithVariableIntentionAction.java
@@ -27,7 +27,7 @@ public String getFamilyName() {
   @Override
   public boolean isAvailableOnDeclarationStatement(PsiDeclarationStatement context) {
     PsiElement[] declaredElements = context.getDeclaredElements();
-    if (declaredElements.length > 1) {
+    if (declaredElements.length != 1) {
       return false;
     }
     PsiElement declaredElement = declaredElements[0];

diff --git a/src/main/resources/messages/lombokBundle.properties b/src/main/resources/messages/lombokBundle.properties
@@ -20,14 +20,7 @@ daemon.donate.title=Lombok support plugin updated to v{0}
 daemon.donate.content=<br/>\
 Helpful? <b><a href="https://www.paypal.me/mplushnikov">Donate with PayPal</a></b><br/><br/>\
 Fixes:<br/>\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/570">#570</a>): Better support for @Builder.Default (var$set and var$value fields)<br/>\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/754">#754</a>): Intention to convert explicit type to var/val or vice versa, thanks to @Sheigutn (Florian Böhm)<br/>\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/760">#760</a>): Plugin and compiler disagree on @Builder method generation<br/>\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/771">#771</a>): @Data No error message when there is no default constructor in superclass<br/>\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/805">#805</a>): Do not use deprecated constructor injection <br/>\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/pull/807">#807</a>): Do not use ImplicitUsageProvider in GenerateConstructorAction<br/>\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/822">#822</a>): @Builder annotation on multiple methods of same class is broken<br/>\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/825">#825</a>): intellij objects to overriding builder methods when setterPrefix set<br/>\
+- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/923">#923</a>): ArrayIndexOutOfBoundsException in ReplaceExplicitTypeWithVariableIntention<br/>\
   <br>\
   If you find my plugin helpful, donate me using <br><b>\
   <a href="https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick\\&hosted_button_id=3F9HXD7A2SMCN\\&source=url">PayPal</a>\